K8OP-5 Do not create MedusaBackup if MadusaBakupJob did not fully succeed #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzvoncek
force-pushed
the
K8OP-5
branch
3 times, most recently
from
b1c8758 to
a536ff0
Compare
adejanovski
approved these changes
Oct 28, 2024
| @@ -72,9 +72,9 @@ func (r *MedusaBackupJobReconciler) Reconcile(ctx context.Context, req ctrl.Requ | |||
| return ctrl.Result{}, err | |||
| } | |||
|
|
|||
| backup := instance.DeepCopy() | |||
| backupJob := instance.DeepCopy() | |||
There was a problem hiding this comment.
praise: Good call on renaming this for better clarity!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR changes reconciliation of
MedusaBackupJobto not createMedusaBackupif there were failures in the job.It's tricky to test this manually. The only way I found was to kill medusa (the OS process in the container) just after a backup starts.
Which issue(s) this PR fixes:
Fixes #1383
Checklist