Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer cass-operator version for new Task Status fields #1098

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 23, 2023

…de new operations as well as new Status spec

What this PR does:
Updates to cass-operator 1.18.0 dev version, which updates the tasks and status API for CassandraTask.

Which issue(s) this PR fixes:
Fixes #1097

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

…de new operations as well as new Status spec
@burmanm burmanm requested a review from a team as a code owner October 23, 2023 11:51
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1098 (930dc74) into main (b8fdff4) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   57.39%   57.34%   -0.06%     
==========================================
  Files         100      100              
  Lines       10192    10193       +1     
==========================================
- Hits         5850     5845       -5     
- Misses       3832     3836       +4     
- Partials      510      512       +2     
Files Coverage Δ
controllers/control/k8ssandratask_controller.go 64.00% <0.00%> (ø)
apis/control/v1alpha1/k8ssandratask_types.go 72.82% <83.33%> (+0.29%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: Could you add a changelog entry? Then you're good for a merge.

@burmanm burmanm merged commit f972b64 into k8ssandra:main Oct 24, 2023
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to CassandraTasks newer Go api
2 participants