Make HttpManagement.Enabled a pointer #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
olim7t
approved these changes
Oct 19, 2023
| @@ -152,7 +152,7 @@ func NewDeployment(reaper *api.Reaper, dc *cassdcapi.CassandraDatacenter, keysto | |||
| Value: fmt.Sprintf("%d", reaper.Spec.HeapSize.Value()), | |||
| }) | |||
| } | |||
| if reaper.Spec.HttpManagement.Enabled { | |||
| if reaper.Spec.HttpManagement.Enabled != nil && *reaper.Spec.HttpManagement.Enabled { | |||
There was a problem hiding this comment.
[suggestion] not a hard requirement, but there is a library method for this kind of expression
Suggested change
| if reaper.Spec.HttpManagement.Enabled != nil && *reaper.Spec.HttpManagement.Enabled { | |
| if pointer.BoolDeref(reaper.Spec.HttpManagement.Enabled, false) { |
Miles-Garnsey
force-pushed
the
feature/http-management-pointer
branch
from
f7c3348 to
874360e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
- Coverage 57.40% 57.39% -0.01%
==========================================
Files 100 100
Lines 10192 10192
==========================================
- Hits 5851 5850 -1
- Misses 3831 3832 +1
Partials 510 510
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The HttpManagement.Enabled in the Reaper package should be a pointer, to allow for easier distinction between unset and false values. This is not important for k8ssandra-operator (where a default value of false is fine) but is relevant for downstream consumers of the types, in particular MC, where we would like to have a default value of true.
Which issue(s) this PR fixes:
Hotfix.
Checklist