switch the golangci install method #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| @@ -45,6 +45,8 @@ GOLANGCI_LINT = $(GOBIN)/golangci-lint | |||
| # we keep it fixed to avoid it from unexpectedly failing on the project | |||
| # in case of a version bump | |||
| GOLANGCI_LINT_VER = v1.51.2 | |||
| export GOLANGCI_LINT_CACHE = /tmp/.cache | |||
There was a problem hiding this comment.
nit: why not put it under current dir ? or under ./build/.cache
There was a problem hiding this comment.
done please take another look when you have time
SchSeba
force-pushed
the
fix_unittest
branch
2 times, most recently
from
9fddae5
to
afcbb55
Compare
Signed-off-by: Sebastian Sch <[email protected]>
adrianchiris
approved these changes
Jun 3, 2024
adrianchiris
merged commit 95e96ac
into
k8snetworkplumbingwg:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.