Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linux-headers apk from Dockerfile #84

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Feb 13, 2024

Referring an exact version of the linux-headers package might break image building process, with errors like:

#11 0.185 fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/community/x86_64/APKINDEX.tar.gz
#11 0.459 ERROR: unable to select packages:
#11 0.461   linux-headers-6.5-r0:
#11 0.461     breaks: build-dependencies-20240212.104211[linux-headers~6.3]
#11 0.461   build-dependencies-20240212.104211:
#11 0.461     masked in: cache
#11 0.461     satisfies: world[build-dependencies=20240212.104211]
#11 ERROR: process "/bin/sh -c apk add --no-cache --virtual build-dependencies build-base=~0.5 linux-headers=~6.3" did not complete successfully: exit code: 2

Comes from:

@almaslennikov I'm not sure why we introduced the linux-headers package. I can remove it if it's not really needed. Please, take a look

Note: no new image is currently published for this repository due to this error. (see action log)

Referring an exact version of the linux-headers package might break image
building process, with errors like:

```
```

Not putting a pinnged version make hadolint complaining:

```
Dockerfile:8 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
```

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke changed the title Avoid referring linux-headers apk exact version Remove linux-headers apk from Dockerfile Feb 13, 2024
@zeeke
Copy link
Member Author

zeeke commented Feb 19, 2024

@adrianchiris, @e0ne, @SchSeba please take a look at his

Copy link
Contributor

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit fc002af into k8snetworkplumbingwg:master Feb 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants