-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish container image #122
Open
zeeke
wants to merge
3
commits into
k8snetworkplumbingwg:master
Choose a base branch
from
zeeke:us/publish-images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Image build | ||
on: [pull_request] | ||
jobs: | ||
build: | ||
name: Image plugin | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Build container image | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
push: false | ||
tags: ghcr.io/${{ github.repository }}:latest | ||
file: images/Dockerfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
name: Image push for master | ||
on: | ||
push: | ||
branches: | ||
- master | ||
env: | ||
image-push-owner: 'k8snetworkplumbingwg' | ||
jobs: | ||
|
||
push: | ||
name: Image push | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Login to GitHub Container Registry | ||
if: ${{ github.repository_owner == env.image-push-owner }} | ||
uses: docker/login-action@v3 | ||
with: | ||
registry: ghcr.io | ||
username: ${{ github.repository_owner }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Push container image | ||
if: ${{ github.repository_owner == env.image-push-owner }} | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
push: true | ||
tags: | | ||
ghcr.io/${{ github.repository }}:latest | ||
file: images/Dockerfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: Image push release | ||
on: | ||
push: | ||
tags: | ||
- v* | ||
env: | ||
image-push-owner: 'k8snetworkplumbingwg' | ||
jobs: | ||
push: | ||
name: Image push | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Login to GitHub Container Registry | ||
if: ${{ github.repository_owner == env.image-push-owner }} | ||
uses: docker/login-action@v3 | ||
with: | ||
registry: ghcr.io | ||
username: ${{ github.repository_owner }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Docker meta | ||
id: docker_meta | ||
uses: docker/metadata-action@v5 | ||
with: | ||
images: ghcr.io/${{ github.repository }} | ||
flavor: | | ||
latest=false | ||
|
||
- name: Push container image | ||
if: ${{ github.repository_owner == env.image-push-owner }} | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
push: true | ||
tags: | | ||
ghcr.io/${{ github.repository }}:stable | ||
${{ steps.docker_meta.outputs.tags }} | ||
file: images/Dockerfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# This Dockerfile is used to build the image available on DockerHub | ||
FROM docker.io/golang:1.23 AS build | ||
|
||
WORKDIR /usr/src/bond-cni | ||
COPY . . | ||
RUN make build-bin | ||
|
||
FROM docker.io/alpine:latest | ||
LABEL org.opencontainers.image.source=https://github.com/k8snetworkplumbingwg/bond-cni | ||
WORKDIR / | ||
COPY --from=build /usr/src/bond-cni/bin . | ||
COPY LICENSE . | ||
COPY images/entrypoint.sh . | ||
|
||
CMD ["/entrypoint.sh"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/sh | ||
|
||
set -u -e -x | ||
|
||
CNI_BIN_DIR=${CNI_BIN_DIR:-"/host/opt/cni/bin/"} | ||
|
||
cp -f /bond $CNI_BIN_DIR | ||
|
||
# Unless told otherwise, sleep forever. | ||
# This prevents Kubernetes from restarting the pod repeatedly. | ||
should_sleep=${SLEEP:-"true"} | ||
echo "Done configuring CNI. Sleep=$should_sleep" | ||
while [ "$should_sleep" == "true" ]; do | ||
sleep 1000000000000 | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
apiVersion: apps/v1 | ||
kind: DaemonSet | ||
metadata: | ||
name: bond-cni | ||
labels: | ||
tier: node | ||
app: bond-cni | ||
spec: | ||
selector: | ||
matchLabels: | ||
app: bond-cni | ||
updateStrategy: | ||
type: RollingUpdate | ||
rollingUpdate: | ||
maxUnavailable: 10% | ||
template: | ||
metadata: | ||
labels: | ||
tier: node | ||
app: bond-cni | ||
spec: | ||
nodeSelector: | ||
kubernetes.io/arch: amd64 | ||
kubernetes.io/os: linux | ||
tolerations: | ||
- key: node-role.kubernetes.io/master | ||
operator: Exists | ||
effect: NoSchedule | ||
containers: | ||
- name: bond-cni-plugin | ||
image: ghcr.io/k8snetworkplumbingwg/bond-cni:latest | ||
resources: | ||
requests: | ||
cpu: "10m" | ||
memory: "15Mi" | ||
volumeMounts: | ||
Eoghan1232 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: cnibin | ||
mountPath: /host/opt/cni/bin/ | ||
volumes: | ||
- name: cnibin | ||
hostPath: | ||
path: /opt/cni/bin/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this one and only use the tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping the
stable
tag is not bad. This way, if a consumer wants the latest from master, it can targetlatest
, if he wants the latest released version can usestable
, if he wants a specific tags can use it directly (e.g. v1.0.1)