Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework cache #19

Merged
merged 2 commits into from
Nov 16, 2023
Merged

feat: rework cache #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc6bb3
feat: add project_id attribute to cache object
matthisholleville Nov 12, 2023
ee5a662
feat: bump buf version & rework cache structure
matthisholleville Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
BUF_VERSION=v1.6.0
BUF_VERSION=v1.28.0
TAG=protobuf-v0.1.4
guard-%:
@ if [ "${${*}}" = "" ]; then \
Expand Down
21 changes: 19 additions & 2 deletions protobuf/schema/v1/schema.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,28 @@
string status = 1;
}

message Cache {

Check failure on line 77 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Previously present field "4" with name "container_name" on message "Cache" was deleted.
oneof cache_type {
S3Cache s3_cache = 1;

Check failure on line 79 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "1" with name "s3_cache" on message "Cache" changed option "json_name" from "region" to "s3Cache".

Check failure on line 79 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "1" on message "Cache" moved from outside to inside a oneof.

Check failure on line 79 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "1" on message "Cache" changed type from "string" to "message".

Check failure on line 79 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "1" on message "Cache" changed name from "region" to "s3_cache".
AzureCache azure_cache = 2;

Check failure on line 80 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "2" with name "azure_cache" on message "Cache" changed option "json_name" from "bucketName" to "azureCache".

Check failure on line 80 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "2" on message "Cache" moved from outside to inside a oneof.

Check failure on line 80 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "2" on message "Cache" changed type from "string" to "message".

Check failure on line 80 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "2" on message "Cache" changed name from "bucket_name" to "azure_cache".
GCSCache gcs_cache = 3;

Check failure on line 81 in protobuf/schema/v1/schema.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Field "3" with name "gcs_cache" on message "Cache" changed option "json_name" from "storageAccount" to "gcsCache".
}
}

message S3Cache {
string region = 1;
string bucket_name = 2;
}

message AzureCache {
string storage_account = 1;
string container_name = 2;
}

message GCSCache {
string region = 1;
string bucket_name = 2;
string storage_account = 3;
string container_name = 4;
string project_id = 3;
}

message Trivy {
Expand Down
Loading