Fix kubeconfig merge with existing config #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alankan-finocomp <[email protected]>
|
The intention is that if supply a dedicated kubeconfig location for the k3s-ansible controlled clusters, we don't do any merging or overriding. |
dereknola
requested changes
Jul 26, 2024
| regexp: 'name: default' | ||
| replace: 'name: {{ cluster_context }}' | ||
| regexp: 'default' | ||
| replace: '{{ cluster_context }}' | ||
| delegate_to: 127.0.0.1 | ||
| become: false | ||
|
|
||
| - name: Merge with any existing kubeconfig on control node | ||
| when: kubeconfig != "~/.kube/config" |
There was a problem hiding this comment.
Suggested change
| when: kubeconfig != "~/.kube/config" | |
| when: kubeconfig == "~/.kube/config.new" |
| @@ -151,17 +151,17 @@ | |||
| when: kubeconfig != "~/.kube/config" | |||
There was a problem hiding this comment.
Suggested change
| when: kubeconfig != "~/.kube/config" | |
| when: kubeconfig == "~/.kube/config.new" |
dereknola
requested changes
Jul 26, 2024
| KUBECONFIG={{ kubeconfig }} kubectl config set-context {{ cluster_context }} --user={{ cluster_context }} --cluster={{ cluster_context }} | ||
| KUBECONFIG={{ kubeconfig }} kubectl config view --flatten > ${TFILE} | ||
| KUBECONFIG={{ kubeconfig }}:~/.kube/config kubectl config set-context {{ cluster_context }} --user={{ cluster_context }} --cluster={{ cluster_context }} | ||
| KUBECONFIG={{ kubeconfig }}:~/.kube/config kubectl config view --flatten > ${TFILE} | ||
| mv ${TFILE} {{ kubeconfig }} |
There was a problem hiding this comment.
Suggested change
| mv ${TFILE} {{ kubeconfig }} | |
| mv ${TFILE} ~/.kube/config |
|
There is also the block which can cause a full overwrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since the existing config file was not in scope, the commands did not perform anything.
To fix it, I include the existing kubeconfig path in KUBECONFIG variable such that the YAML contents are merged when it prints out via
kubectl config view --flattenAlso, replacing keyword "default" with ansible variable
kube_configcan also help replace thecurrent-contextin the kubeconfig file.Linked Issues
#350