Judge before UseCachedDecoderOut #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Nov 17, 2023
| if (is_batch_decoder_out_cached) { | ||
| auto &r = result->front(); | ||
| std::vector<int64_t> decoder_out_shape = r.decoder_out.GetTensorTypeAndShapeInfo().GetShape(); | ||
| decoder_out = Ort::Value::CreateTensor<float>(model_->Allocator(), decoder_out_shape.data(), decoder_out_shape.size()); |
There was a problem hiding this comment.
This line only allocates memory for decoder_out but it does not initialize it.
Please use
sherpa-onnx/sherpa-onnx/csrc/cat-test.cc
Line 126 in eeda1e1
to concatenate the
r.decoder_out along the batch dimension.
There was a problem hiding this comment.
Sorry for my mistake. Cat() seems to be a more overloaded option.
|
By the way, could you follow sherpa-onnx/sherpa-onnx/csrc/online-wenet-ctc-model.cc Lines 74 to 75 in eeda1e1 to replace Clone() with View() in other code in a separate PR?
|
HieDean
force-pushed
the
judge_before_UseCachedDecoderOut
branch
from
87e9e58 to
6352006
Compare
|
Thank you for your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cached decoder out of the entire batch exists, then use it.