'try to fix 'compute_fbank_kespeech_splits.py: error: unrecognized arguments: --speed-perturb true'' #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
requested changes
Nov 27, 2024
| @@ -52,7 +52,13 @@ def get_parser(): | |||
| default=80, | |||
| help="""The number of mel bins for Fbank""", | |||
| ) | |||
|
|
|||
| # 修改： 添加 指定参数 speed-perturb | |||
There was a problem hiding this comment.
Could you remove the comment or use English instead of Chinese?
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Could you remove everything from the folder .idea?
pkufool
reviewed
Nov 27, 2024
| @@ -52,7 +52,13 @@ def get_parser(): | |||
| default=80, | |||
| help="""The number of mel bins for Fbank""", | |||
| ) | |||
|
|
|||
| # 修改： 添加 指定参数 speed-perturb | |||
There was a problem hiding this comment.
Please comment in English, thanks!
| type=str2bool, | ||
| default=False, | ||
| help="Use WhisperFbank instead of Fbank. Default: False.", | ||
| ) |
pkufool
reviewed
Nov 27, 2024
| "--whisper-fbank", | ||
| type=str2bool, | ||
| "--speed-perturb", | ||
| type=bool, |
There was a problem hiding this comment.
I think using str2bool is more generic.
csukuangfj
requested changes
Nov 27, 2024
| @@ -54,11 +54,12 @@ def get_parser(): | |||
| ) | |||
|
|
|||
| parser.add_argument( | |||
| "--whisper-fbank", | |||
| "--speed-perturb", | |||
There was a problem hiding this comment.
could you only add new arguments but keep the existing ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I execute '/audio_icefall/icefall/egs/multi_zh-hans/ASR/prepare.sh' by './prepare.sh/ --stage 12 --stop-stage 12', a bug came up with 'compute_fbank_kespeech_splits.py: error: unrecognized arguments: --speed-perturb true'. So I check the '/audio_icefall/icefall/egs/multi_zh-hans/ASR/local/compute_fbank_kespeech_splits.py' and I find there's no param named '--speed-perturb', so I modified the '/audio_icefall/icefall/egs/multi_zh-hans/ASR/local/compute_fbank_kespeech_splits.py' and '/audio_icefall/icefall/egs/multi_zh-hans/ASR/local/compute_fbank_kespeech_dev_test.py'. Hope this could be helpful.