ASR SEAME Recipe #1582
Open
ASR SEAME Recipe #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinZr
reviewed
Apr 6, 2024
There was a problem hiding this comment.
hi amir, thank you for your contribution!
but im wondering perhaps you want to use a separate export.py rather than applying modification to the one used by librispeech?
There was a problem hiding this comment.
Since both are based on same zipformer architecture, I think they can use the same export, the difference is in the parameters. I could also create a separate one if needed.
|
A separate one would be better, otherwise backward compatibility might be
broken since you have also modified the default parameters of the export
script.
…On Sat, Apr 6, 2024 at 1:03 PM Amir Hussein ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On egs/librispeech/ASR/zipformer/export.py
<#1582 (comment)>:
Since both are based on same zipformer architecture, I think they can use
the same export, the difference is in the parameters. I could also create a
separate one if needed.
—
Reply to this email directly, view it on GitHub
<#1582 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOON42DLBNV26GBVPIGFVMLY356ZNAVCNFSM6AAAAABFZHCDSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBUGQ2DEMBXHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the SEAME recipe and includes the following: