-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test of managed service deployment #873
e2e test of managed service deployment #873
Conversation
6eb2fed
to
4dcd7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, a couple of questions/comments, and the PR should be postponed until the e2e CI is ready (as of now and to my understanding it is blocked due to the #871). After addressing the issue, the PR should be then checked with the e2e tests job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. One small question:
Should we also test service deployment for other providers or hosted environments? I’m asking because once #752 is implemented, some providers might be skipped, and service deployment may not be checked at all. But, if this code is expected to change soon, it’s fine as is for now.
1b50d68
to
0cdf5ca
Compare
3b1d949
to
d3b263f
Compare
d3b263f
to
9a8bfd0
Compare
e4df9c0
to
b5bd1d6
Compare
b5bd1d6
to
10e370c
Compare
10e370c
to
f04cc90
Compare
f04cc90
to
9fcbfcb
Compare
9fcbfcb
to
c0ade0b
Compare
c0ade0b
to
f98e341
Compare
f98e341
to
6db508b
Compare
@zerospiel @eromanova @Kshatrix colleagues, e2e tests are flacky. What's especially annoying is that their stability depends on the cloud provider. GH actions history shows, that tests added in this PR passes in case kcm able to deploy the cluster. Pls approve and merge. |
6db508b
to
4551fcf
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
4551fcf
to
23473ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed previously since tests are failing randomly (in other PRs as well) we can't wait indefinitely for the tests to pass.
Merging without green tests. Code itself looks good, but it must be revisited after service templates will be separated to the catalog repo
Fixes: #849 #850