Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - e2e test debug #676

Closed
wants to merge 1 commit into from

Conversation

kylewuolle
Copy link
Contributor

This is a temporary measure to allow changes to the github workflow file on PRs so we can figure out why the e2e tests are currently failing. Once those are fixed we will set it back to pull_request_target.

Copy link
Contributor

@slysunkin slysunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the same in my experiments

@a13x5
Copy link
Collaborator

a13x5 commented Nov 21, 2024

I suggest separating e2e tests in a separate workflow and keep pull_request_target for build and unit tests.

@kylewuolle
Copy link
Contributor Author

That might be the only way for this to work. In the meantime I might have figured out another way to figure out what's going on.

@kylewuolle kylewuolle closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants