Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airgap] Fix values processing for 2A extensions #659

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

eromanova
Copy link
Collaborator

This PR fixes the values processing for 2A extensions:

  1. Run helm template before getting values for extensions:
${HELM} template "${template}" --show-only "${k0sconfig}" | $YQ e "${extensions_path}.charts[] | select(.chartname == \"*$chartname*\") | .values" > ${name}-values.yaml

instead of

grep -vw "{{" $template | $YQ e "${extensions_path}.charts[] | select(.chartname == \"*$chartname*\") | .values" > ${name}-values.yaml
  1. Rename templates_dir -> TEMPLATES_DIR

Closes #654

@eromanova eromanova marked this pull request as ready for review November 18, 2024 14:14
@Kshatrix Kshatrix merged commit edfc035 into k0rdent:main Nov 18, 2024
5 checks passed
@eromanova eromanova deleted the fix-654 branch November 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Airgap bundle build failed
2 participants