EKS e2e tests #539
Closed
EKS e2e tests #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slysunkin
added
the
test e2e
slysunkin
force-pushed
the
HMC-387
branch
2 times, most recently
from
1a8bef9 to
f5142c1
Compare
slysunkin
requested review from
Kshatrix,
squizzi,
eromanova and
a13x5
as code owners
squizzi
reviewed
Oct 29, 2024
| }).WithTimeout(60 * time.Minute).WithPolling(30 * time.Second).Should(Succeed()) | ||
|
|
||
| // --- clean up --- | ||
| templateBy(managedcluster.TemplateAWSStandaloneCP, "deleting the ManagedCluster for EKS") |
There was a problem hiding this comment.
This shouldn't represent clean up, but rather deletion and testing deletion. For cleanup of failed tests you should edit the dev-aws-nuke target/cloud-nuke config to also cleanup any created/orphaned EKS resources.
squizzi
reviewed
Oct 29, 2024
|
This PR had to be a from a branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing #387
EKS E2E tests