Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility attributes: add API support, propagation and checks #422

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Compatibility attributes: add API support, propagation and checks #422

merged 3 commits into from
Oct 15, 2024

Conversation

zerospiel
Copy link
Contributor

@zerospiel zerospiel commented Oct 2, 2024 •
edited
Loading

  • Cluster/Service/Provider Templates now have support for compatibility attributes
  • Managed/Management Clusters now have support to report the compatibility attributes
  • amends to the templates controller in regards of the API changes
  • amends to other parts of the code
  • fill out statuses with the new attributes
    for managedclustes,managements,*templates
    resources
  • fix a couple of logical errors
  • check compatibility attributes in the
    admission controller
  • tests
  • fix typos

Closes #400 #354

@zerospiel zerospiel force-pushed the attr_enforcement branch 2 times, most recently from ea4586c to e8a45c0 Compare October 4, 2024 12:49
@zerospiel zerospiel marked this pull request as ready for review October 4, 2024 12:50
@zerospiel zerospiel force-pushed the attr_enforcement branch 2 times, most recently from ec6f305 to 45809a7 Compare October 4, 2024 15:15
@zerospiel zerospiel changed the title Enforce compatibility attributes Compatibility attributes: add API support, propagation and checks Oct 4, 2024
@zerospiel zerospiel mentioned this pull request Oct 4, 2024
Closed
@zerospiel zerospiel force-pushed the attr_enforcement branch 3 times, most recently from ade73b2 to 9027b3d Compare October 7, 2024 10:37
@zerospiel zerospiel force-pushed the attr_enforcement branch 2 times, most recently from b70714f to 070dec9 Compare October 7, 2024 14:35
@zerospiel zerospiel linked an issue Oct 7, 2024 that may be closed by this pull request
API changes to support compatibility attributes #354
Closed
@zerospiel zerospiel mentioned this pull request Oct 7, 2024
Merged
@zerospiel zerospiel force-pushed the attr_enforcement branch 3 times, most recently from a879a9f to ac4a463 Compare October 8, 2024 07:31
Kshatrix
Kshatrix requested changes Oct 8, 2024
View reviewed changes
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/managedcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/managedcluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/providertemplate_types.go Show resolved Hide resolved
api/v1alpha1/templates_common.go Outdated Show resolved Hide resolved
api/v1alpha1/templates_common.go Show resolved Hide resolved
api/v1alpha1/providertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/servicetemplate_types.go Outdated Show resolved Hide resolved
@zerospiel zerospiel requested a review from Kshatrix October 8, 2024 13:57
@zerospiel zerospiel force-pushed the attr_enforcement branch 4 times, most recently from b2ec73f to 6e79a5c Compare October 10, 2024 08:48
@zerospiel
Copy link
Contributor Author

@squizzi @Kshatrix @a13x5 requesting CR, the PR is big enough, and already awaits some time to be reviewed and with each merge, it's harder and harder to keep it up-to-date

Kshatrix
Kshatrix requested changes Oct 11, 2024
View reviewed changes
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/clustertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/providertemplate_types.go Outdated Show resolved Hide resolved
api/v1alpha1/providertemplate_types.go Outdated Show resolved Hide resolved
internal/webhook/managedcluster_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
@zerospiel
Add support for compatibility attributes
9c9aeec 
* Cluster/Service/Provider Templates now have
  support for compatibility attributes
* Managed/Management Clusters now have
  support to report the compatibility
  attributes
* amends to the templates controller
  in regards of the API changes
* amends to other parts of the code

Closes k0rdent#354
@zerospiel
Enforce compatibility attributes
bd199f4 
* fill out statuses with the new attributes
  for managedclustes,managements,*templates
  resources
* fix a couple of logical errors
* check compatibility attributes in the
  admission controller
* tests
* fix typos

Closes k0rdent#400 k0rdent#354
@zerospiel
Addressed comments on compatibility attrs
846289e 
* amends to descs and fix typos
* correctly parse providers
* changed providers anno separator
* enforce CAPI version check
  in providertemplates
* amends to the API regarding
  CAPI version compatibility
@Kshatrix Kshatrix merged commit 545f2ba into k0rdent:main Oct 15, 2024
3 checks passed
@zerospiel zerospiel deleted the attr_enforcement branch October 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Kshatrix approved these changes

@squizzi squizzi Awaiting requested review from squizzi

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
k0rdent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility attributes: implement enforcement API changes to support compatibility attributes
2 participants
@zerospiel @Kshatrix