Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate available upgrades for managed clusters #391

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Validate available upgrades for managed clusters #391

merged 4 commits into from
Oct 29, 2024

Conversation

eromanova
Copy link
Contributor

@eromanova eromanova commented Sep 25, 2024 •
edited
Loading

  1. Added new field: status.availableUpdates to the ManagedCluster.
  2. Validate that the new template is in the list of availableUpdates.

Closes #372

@eromanova eromanova self-assigned this Sep 25, 2024
zerospiel
zerospiel requested changes Sep 25, 2024
View reviewed changes
api/v1alpha1/templates_common.go Outdated Show resolved Hide resolved
internal/templateutil/interface.go Outdated Show resolved Hide resolved
internal/templateutil/interface.go Outdated Show resolved Hide resolved
internal/templateutil/state.go Outdated Show resolved Hide resolved
internal/templateutil/state.go Outdated Show resolved Hide resolved
internal/webhook/managedcluster_webhook.go Outdated Show resolved Hide resolved
internal/templateutil/state.go Outdated Show resolved Hide resolved
internal/webhook/managedcluster_webhook.go Outdated Show resolved Hide resolved
internal/webhook/managedcluster_webhook.go Outdated Show resolved Hide resolved
internal/webhook/managedcluster_webhook_test.go Outdated Show resolved Hide resolved
@eromanova eromanova force-pushed the clusters-upgrade-validation branch 4 times, most recently from 1fcaa14 to d5d6aeb Compare September 26, 2024 08:32
@eromanova eromanova marked this pull request as draft September 26, 2024 09:35
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from d5d6aeb to 9c8a9e3 Compare September 26, 2024 11:34
@eromanova eromanova marked this pull request as ready for review September 26, 2024 11:34
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from 9c8a9e3 to d4ff7ee Compare September 27, 2024 07:01
zerospiel
zerospiel previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eromanova eromanova marked this pull request as draft October 17, 2024 13:17
@eromanova eromanova force-pushed the clusters-upgrade-validation branch 2 times, most recently from 4901311 to 635d581 Compare October 19, 2024 07:45
@eromanova eromanova marked this pull request as ready for review October 19, 2024 07:46
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from 635d581 to 765866c Compare October 21, 2024 19:10
@eromanova eromanova requested a review from Kshatrix October 22, 2024 12:30
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from 765866c to a037742 Compare October 24, 2024 10:55
@eromanova eromanova force-pushed the clusters-upgrade-validation branch 2 times, most recently from 8fbf9f0 to 120f665 Compare October 24, 2024 13:43
@eromanova eromanova requested a review from Kshatrix October 24, 2024 13:49
@eromanova eromanova marked this pull request as draft October 28, 2024 09:37
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from 120f665 to ab7a35f Compare October 28, 2024 09:51
@eromanova eromanova marked this pull request as ready for review October 28, 2024 09:51
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from ab7a35f to c8508d4 Compare October 28, 2024 09:58
@eromanova eromanova requested a review from zerospiel October 28, 2024 14:17
zerospiel
zerospiel reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple questions, if they are not applicable, then pls resolve them and then LGTM

api/v1alpha1/managedcluster_types.go Outdated Show resolved Hide resolved
internal/controller/managedcluster_controller.go Show resolved Hide resolved
internal/controller/managedcluster_controller.go Outdated Show resolved Hide resolved
@eromanova eromanova marked this pull request as draft October 28, 2024 15:22
@eromanova
Reflect available upgrades in cluster status: addressed comments
ab3f033 
* Several watcher improvements: events, code enhancements
* Changed availableUpgrades type into []string
@eromanova eromanova marked this pull request as ready for review October 28, 2024 15:36
@eromanova eromanova marked this pull request as draft October 28, 2024 15:36
@eromanova eromanova force-pushed the clusters-upgrade-validation branch from f6e5dde to ab3f033 Compare October 28, 2024 15:37
@eromanova eromanova marked this pull request as ready for review October 28, 2024 15:39
@eromanova eromanova merged commit 2401c11 into k0rdent:main Oct 29, 2024
5 checks passed
@eromanova eromanova deleted the clusters-upgrade-validation branch October 29, 2024 10:53
squizzi pushed a commit to squizzi/hmc that referenced this pull request Oct 29, 2024
@eromanova @squizzi
Validate available upgrades for managed clusters (k0rdent#391)
8845c78 
* Set availableUpgrades in ManagedCluster status
* Validate availability of the ManagedCluster update
* Reflect available upgrades in cluster status: addressed comments
* Several watcher improvements: events, code enhancements
* Changed availableUpgrades type into []string
bnallapeta pushed a commit to bnallapeta/hmc that referenced this pull request Nov 15, 2024
@eromanova
Validate available upgrades for managed clusters (k0rdent#391)
317a6ea 
* Set availableUpgrades in ManagedCluster status
* Validate availability of the ManagedCluster update
* Reflect available upgrades in cluster status: addressed comments
* Several watcher improvements: events, code enhancements
* Changed availableUpgrades type into []string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Kshatrix approved these changes

@zerospiel zerospiel zerospiel approved these changes

@squizzi squizzi Awaiting requested review from squizzi

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

Assignees

@eromanova eromanova

Labels
None yet
Projects
k0rdent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ManagedCluster's upgrade to supported templates only
3 participants
@eromanova @zerospiel @Kshatrix