-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get status.conditions from CAPI operator during updateComponentsStatus
#341
Get status.conditions from CAPI operator during updateComponentsStatus
#341
Conversation
06fe1e2
to
83d09f5
Compare
I can probably add some unit tests to this using Edit: This apparently isn't trivial to test in |
I'll plan to add an e2e test in a follow-up once the controller tests have been refactored as part of #360 |
7e84fac
to
62b1c3a
Compare
8f4437e
to
552ec53
Compare
2134943
to
f6441f1
Compare
53ba0e5
to
559d10b
Compare
559d10b
to
3fd8c05
Compare
721fd70
to
23df058
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some resolved conversations aren't resolved for some reason.
Several other notes, mostly minor
23df058
to
2905c9a
Compare
* Differentiate status into own package Signed-off-by: Kyle Squizzato <[email protected]>
Signed-off-by: Kyle Squizzato <[email protected]>
Signed-off-by: Kyle Squizzato <[email protected]>
acc8d45
to
23fe371
Compare
@eromanova another rebase cleared your review, if you don't mind approving again |
Signed-off-by: Kyle Squizzato <[email protected]>
…us` (k0rdent#341) * Differentiate status into own package * Use struct for resource condition return, address review * Filter by namespace within GetResourceConditions * Fix linting issues Signed-off-by: Kyle Squizzato <[email protected]>
In this PR we now update our component statuses by iterating the provider CRDs affiliated with CAPI operator and returning a status error if any of the
status.conditions
areFalse
or if we cannot obtain any information pertaining to status condition. For example:In this case
cluster-api-provider-aws
and-azure
are not yet installed:In this case
cluster-api-provider-aws
is reporting some status conditions false:In this case
cluster-api-provider-aws
has nostatus.conditions
because something is going wrong. Perhaps we could add some additional statuses for special circumstances; here it's becauseaws-variables
does not yet exist yet, but I couldn't find anyway to assume this type of circumstance, capi-operator doesn't produce any event in this case, it only generates a log.Closes #235