-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added boolinq::mut_from and modified for each to be able to mutate #67
base: master
Are you sure you want to change the base?
Conversation
@LennardR could you restore updated formatting to keep changes more focused? |
Yeah, don't know how that happend. |
@@ -32,6 +32,7 @@ namespace boolinq { | |||
// | |||
|
|||
struct LinqEndException {}; | |||
struct LinqNonMutableException {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't utilize the same LinqEndException
exception for this mutable case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can utilize the same exception. You can remove the LinqNonMutableException completely.
But for Debugging and using the Lib I think it is cleaner to have a dedicated Exception.
I see compilation error on GCC and Clang is that you use function template param T while the class has same template name T: https://app.travis-ci.com/github/k06a/boolinq/jobs/558567721#L631-L641
Try to rename the template parameter name to something else. |
Currently compiles only with MSVC!
Propeses a Solution for #55 by introducing a mut_from function.
To enable the normal from function to be able to create mutable Linq Objects would require extensive reworking of existing code.