Add sections to BlueJ terminal to divide up different method calls #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string == comparisons, into an actual enum.
…hod in LineDisplay, ready for re-use.
…ke our scope highlighting) around sections of output from different methods.
PwtKCL
approved these changes
Jan 24, 2024
| @@ -889,6 +909,7 @@ public void close() { } | |||
| private class TerminalWriter extends Writer | |||
| { | |||
| private boolean isErrorOut; | |||
| private AtomicInteger pendingWrites = new AtomicInteger(0); | |||
There was a problem hiding this comment.
Although the name seems clear, I'd suggest to add a comment to describe the nature of this variable as when looking at its type only, it might not be obvious what it "counts".
| // The line may be negative in some circumstances (see Section, below). | ||
| // In this case, column should be ignored. If the column is Integer.MAX_VALUE | ||
| // it means to take the whole line as included, no matter how long. | ||
| // Both column and line are zero-based. |
There was a problem hiding this comment.
I understand the comment but I don't see how it applies to the method in the record.
| } | ||
|
|
||
| // Get the current end position of the content as an end position | ||
| // This is different to getCurStart() because if the content ends if a newline |
There was a problem hiding this comment.
Small typo near the end of the line "if a newline" --> "is a newline"
|
I've done all the suggestions -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a change recently discussed in the meeting/on the Blueroom. It borrows BlueJ's scope highlighting mechanism to add grey section markers around each bit of output in the terminal, showing which method call it is from. It also adds a tooltip on hover, which tells you what the method call was. Finally, it clears the stderr pane on each method call (Michael requested this).