Curl_curl function shoud be k * k' - I abs2(k) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions quicker (#9) * not working yet * works without needing residues * works in most cases except large negative kz * newberger tests pass except real poles * all tests pass with fallback to slow method for real poles * all tests now pass * this will be release 0.2.0 * remove dead code * amendements from coverage report * this makes tests go faster * forgot begin statement * works but purely real pole is inaccurate * never use this constructor for Tolerance * start with fewer points for adapative residue calc * actually make it 0.1.8 - not api breaking
* bugfix Dual of besselix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 25 25
Lines 1088 1089 +1
=======================================
+ Hits 1087 1088 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl_curlhas never actually been exactly that but rather a Re (real) version of it. It has never reflected that the differential operatord/dxhas turned into a Fourierim k. It has always just beenk * k' - I(3) * abs2(k)wherek=[k_perp, 0, k_parallel], i.e. the imaginary numberimand associated minus signs have already been taken care of.This PR does not indicate a mathematical bug but rather one of innaccurate nomenclature.