mei: vsc: Do not re-enable interrupt from vsc_tp_reset()

The only 2 callers of vsc_tp_reset() are: 1. mei_vsc_hw_reset(), which immediataly calls vsc_tp_intr_disable() afterwards. 2. vsc_tp_shutdown() which immediately calls free_irq() afterwards. So neither actually wants the interrupt to be enabled after resetting the chip and having the interrupt enabled for a short time afer the reset is undesirable. Drop the enable_irq() call from vsc_tp_reset(), so that the interrupt is left disabled after vsc_tp_reset(). Link: intel/ivsc-driver#51 Signed-off-by: Hans de Goede <[email protected]>
jwrdegoede · Nov 3, 2024 · 84507cb · 84507cb
1 parent ae3e890
commit 84507cb
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
@@ -256,8 +256,6 @@ static int mei_vsc_hw_reset(struct mei_device *mei_dev, bool intr_enable)
 
 	vsc_tp_reset(hw->tp);
 
-	vsc_tp_intr_disable(hw->tp);
-
 	return vsc_tp_init(hw->tp, mei_dev->dev);
 }
 

diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
@@ -364,8 +364,6 @@ void vsc_tp_reset(struct vsc_tp *tp)
 	gpiod_set_value_cansleep(tp->wakeupfw, 1);
 
 	atomic_set(&tp->assert_cnt, 0);
-
-	enable_irq(tp->spi->irq);
 }
 EXPORT_SYMBOL_NS_GPL(vsc_tp_reset, VSC_TP);
-Original file line number
+Diff line change
@@ Expand Up @@
     	vsc_tp_reset(hw->tp);
-    	vsc_tp_intr_disable(hw->tp);
     	return vsc_tp_init(hw->tp, mei_dev->dev);
     }
@@ Expand Down @@