Adapt to Coq PR #18445, that fixes an issue with multiple signatures of implicit arguments for notations #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for notations. The new (originally intended) behaviour for selecting maximal implicit arguments of a notation for an applied constant in the presence of multiple signatures of implicit arguments. Such notations now behave like ordinary constants or abbreviations for non applied constants, that is, they complete the application with as much implicit arguments as possible. This impacts the notation "naturality[ x ] := (@Naturality _ _ _ _ x)" which is now resolved with 3 trailing implicit arguments, making tactics such as a "srewrite (naturality[foo])" failing with unresolved arguments. It happens that the "naturality" constant mostly uses one signature of implicit arguments. So, the adaptation is to restrict "naturality" to only this signature.
|
@jwiegley could this be merged please? We need it in order to merge coq/coq#18445 in Coq. |
2 tasks
jwiegley
approved these changes
Jan 9, 2024
|
@proux01 Thank you for the ping, I somehow missed this notification e-mail last week. |
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR coq/coq#18445 implements the (originally intended) behaviour for selecting maximal implicit arguments of a notation for an applied constant in the presence of multiple signatures of implicit arguments. Such notation now behaves like ordinary constants or abbreviations for non applied constants, that is, they complete the application with as much implicit arguments as possible.
This impacts the notation
"naturality[ x ] := (@naturality _ _ _ _ x)"which comes with 3 different signatures of implicit arguments. It is now resolved by default with 3 trailing implicit arguments, making tactics such as asrewrite (naturality[unit])later failing with unresolved arguments (e.g. inAdjunction/Hom.v).It happens that the
naturalityconstant is mostly used in practice with only one signature of implicit arguments. So, the proposed adaptation is to restrictnaturalityto only this signature.This is of course not the only way to adapt to coq/coq#18445. Another approach would be e.g. to use
e-tactics so thatsrewriteaccepts to leave unresolved the added implicit arguments.In any cases, the PR is backwards-compatible and can be merged as soon as now.