Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies so build passes #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scottmitch
Copy link

No description provided.

@Scottmitch
Copy link
Author

IIUC the build/ci failure is expected due to the way GitHub actions are setup in this repo. My fork won't have access to this repo's tokens as required by the github action.

@Scottmitch
Copy link
Author

@jwgmeligmeyling - Hello and thank you for your work on this project. Are you actively maintaining this project, and are you willing to merge this PR?

@jwgmeligmeyling
Copy link
Owner

jwgmeligmeyling commented Jan 14, 2021

Hi @Scottmitch , thanks very much for your contribution!

I am intending to continue to support it, but as I am also working on Blaze-Persistence, QueryDSL and Hibernate at the same time I can be incredibly busy...

Honestly I just got the plugin to the point where I needed it to be for my own projects. I am a bit surprised about the traction it managed to get in this short time.

I am definitely willing to integrate your PR's though.

I've noticed that the test check is still failing on this branch. It was passing on the latest commit on master. Do you have any idea why this is? Is it because checkruns exectued in your fork are not allowed to integrate with this repository?

@Scottmitch
Copy link
Author

Is it because checkruns exectued in your fork are not allowed to integrate with this repository?

Its been a while since I have looked at this PR, but seems like a permissions issue HttpError: Resource not accessible by integration. IIRC the build works locally, can you confirm the same on your end? If so this would imply issues with the GitHub Actions setup (e.g. PRs from forks + permissions).

@jwgmeligmeyling
Copy link
Owner

I looked through the security settings and I can't seem to find it.

Is this kind of integration not supported at all for PRs from forks?

ChristopheClermont pushed a commit to ChristopheClermont/checkstyle-github-action that referenced this pull request Apr 3, 2024
…_yarn/node-fetch-2.7.0

Bump node-fetch from 2.6.2 to 2.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants