Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List all solutions #78

Merged
merged 23 commits into from
Mar 17, 2024
Merged

List all solutions #78

merged 23 commits into from
Mar 17, 2024

Conversation

jwg4
Copy link
Owner

@jwg4 jwg4 commented Nov 18, 2023 •
edited
Loading

  • a function which writes down solutiosn up to some max
  • C test for that function
  • Python wrapper which retrieves the count and then uses that as the max - ie get all solutions
  • Python test for that function
  • some docs on how to use - new technical document?
  • clean up the C code?

@jwg4 jwg4 force-pushed the list_all_solutions branch from 161e79e to b815c6f Compare February 10, 2024 16:44
@jwg4 jwg4 force-pushed the list_all_solutions branch from dc40ac6 to 65d8c48 Compare March 17, 2024 15:46
jwg4 and others added 21 commits March 17, 2024 16:07
@jwg4
The new function.
bff4740
@parmentelat @jwg4
the embryo of test_all_solutions.py
da41440
@parmentelat @jwg4
fix import of problems
dc790b6
@jwg4
Reactivate the real part of these tests.
9670fb7
@jwg4
Correct how we call the C code.
6e4b4e5
@jwg4
Correct import.
99fe37d
@jwg4
Clean up this declaration.
2c6b224
@jwg4
Change the name of this function so it doesnt get treated as a test.
9fcecc9
@jwg4
add a test to count solutions.
5f4563b
@jwg4
Make a whole new module for solution counts.
ebb0815
@jwg4
Wrapper for get_solution_countw.
938e82f
@jwg4
Fix the slow running count test.
fe63a5d
@jwg4
Extend wrapper and add tests.
c028d0c
@jwg4
Write the answers to the array correctly.
0d2f836
@jwg4
Correct dimensions of the array.
08bc946
@jwg4
Return a set of solutions.
33f736d
@jwg4
max and solution size are two different things.
64a3ee6
@jwg4
Pad the array row with 0.
a26eccf
@jwg4
Add more get all solutions tests.
24bd67a
@jwg4
Correct helper function for tests.
a7d6c28
@jwg4
Correct the format of the expected value.
ed090b5
@jwg4 jwg4 force-pushed the list_all_solutions branch from 9c4ae58 to ed090b5 Compare March 17, 2024 16:09
@jwg4 jwg4 merged commit 53cd87b into main Mar 17, 2024
48 checks passed
@jwg4 jwg4 mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwg4 @parmentelat