Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing doc #75

Closed
wants to merge 2 commits into from
Closed

Contributing doc #75

wants to merge 2 commits into from

Conversation

parmentelat
Copy link
Contributor

implementing your idea of providing a minimal doc on poetry to potential contributors

@parmentelat
Copy link
Contributor Author

I'd be interested to know more about how to compile the C code on my end
I use a Mac Intel
I reckon this would fit in this new file ?

@parmentelat
Copy link
Contributor Author

apologies, this is mostly already in README.md
forget about this PR

@jwg4
Copy link
Owner

jwg4 commented Nov 19, 2023

Thanks anyway for this!

I am thinking about, when the current changes are ready, changing the documentation a bit. There would be

  1. The main README with basic details about the package, what it does, how to use it.
  2. A document for users which has all the technical info that someone needs who is running this code - for example how edge cases are handled, what errors are possible, how to interpret results. It would be technical but aimed as users not developers.
  3. A document for developers which has all the details about how to build it, other info about contributing, and some details of how it works. It would be aimed only at people who want to work on the code - not just those who want to use it.

The answer to your question is that if you run poetry install it will try to build the C code. If you are set up to compile Python packages in C/C++ it should just work. If not it will give you an error, possibly about python.h. I don't know how you install the python dev packages on Mac, on Linux it's eg apt install python-dev. You obviously need a C compiler too.

If you do have a C compiler but you don't have python dev stuff, you can run the C tests using the Makefile (doesn't require poetry).

@parmentelat parmentelat deleted the contributing branch November 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants