Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store message in be session #315

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Do not store message in be session #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67614dc
Do not store FlashMessages in BE session in CLI context
sfroemkenjw Mar 5, 2024
43cbc8a
Update version to 10.0.12
sfroemkenjw Mar 5, 2024
8470fa2
Set storeInSession to false in func. tests as it is CLI context
sfroemkenjw Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Classes/Helper/MessageHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace JWeiland\Maps2\Helper;

use TYPO3\CMS\Core\Core\Environment;
use TYPO3\CMS\Core\Messaging\AbstractMessage;
use TYPO3\CMS\Core\Messaging\FlashMessage;
use TYPO3\CMS\Core\Messaging\FlashMessageQueue;
Expand Down Expand Up @@ -38,7 +39,7 @@ public function addFlashMessage(string $message, string $title = '', int $severi
$message,
$title,
$severity,
true
!Environment::isCli()
);

$this->getFlashMessageQueue()->enqueue($flashMessage);
Expand Down
5 changes: 5 additions & 0 deletions Documentation/ChangeLog/Index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
ChangeLog
=========

Version 10.0.12
===============

* BUGFIX: Do not store FlashMessages in BE session in CLI context

Version 10.0.11
===============

Expand Down
2 changes: 1 addition & 1 deletion Documentation/Settings.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

project = maps2 (Maps2)
version = 10.0
release = 10.0.11
release = 10.0.12
t3author = Stefan Froemken
copyright = since 2013 by jweiland.net

Expand Down
6 changes: 3 additions & 3 deletions Tests/Functional/Helper/MessageHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function addFlashMessageWithMessageCallsEnqueue(): void
'Hello',
'',
AbstractMessage::OK,
true
false
);

$this->subject->addFlashMessage('Hello');
Expand All @@ -79,7 +79,7 @@ public function addFlashMessageWithMessageAndSubjectCallsEnqueue(): void
'Hello',
'Subject',
AbstractMessage::OK,
true
false
);

$this->subject->addFlashMessage('Hello', 'Subject');
Expand All @@ -99,7 +99,7 @@ public function addFlashMessageWithAllArgumentsCallsEnqueue(): void
'Hello',
'Subject',
AbstractMessage::ERROR,
true
false
);

$this->subject->addFlashMessage('Hello', 'Subject', AbstractMessage::ERROR);
Expand Down
2 changes: 1 addition & 1 deletion ext_emconf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$EM_CONF[$_EXTKEY] = [
'title' => 'Maps2',
'description' => 'Create maps with Marker, Area, Routes or Radius based on Google Maps or OpenStreetMap',
'version' => '10.0.11',
'version' => '10.0.12',
'category' => 'plugin',
'state' => 'stable',
'clearCacheOnLoad' => true,
Expand Down