Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint and coverage #8

Merged
merged 1 commit into from
Feb 10, 2016
Merged

eslint and coverage #8

merged 1 commit into from
Feb 10, 2016

Conversation

VladVega
Copy link
Contributor

eslint and coverage: #7

@VladVega VladVega force-pushed the eslint-and-coverage branch 2 times, most recently from 178cf1a to 6edcb8e Compare February 10, 2016 00:32
@VladVega VladVega force-pushed the eslint-and-coverage branch from 6edcb8e to cb2fc94 Compare February 10, 2016 00:41
@dmehra
Copy link

dmehra commented Feb 10, 2016

Wait up you're lowering the expectations too low, should be able to set branches at 70% and statements/lines at 95%, given this actual report

=============================== Coverage summary ===============================
Statements   : 95.65% ( 22/23 )
Branches     : 70% ( 7/10 )
Functions    : 100% ( 5/5 )
Lines        : 95.65% ( 22/23 )
================================================================================

VladVega added a commit that referenced this pull request Feb 10, 2016
@VladVega
Merge pull request #8 from juttle/eslint-and-coverage
6bff6e2 
eslint and coverage
@VladVega VladVega merged commit 6bff6e2 into master Feb 10, 2016
@VladVega VladVega deleted the eslint-and-coverage branch February 10, 2016 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladVega @dmehra