Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE UI-IC0NPICKER TO WORK WITH ANGULAR 1.3.15 AND BOOTSTRAP 0.13.0 #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sanyam-j
Copy link

No description provided.

@justin-lau
Copy link
Owner

Thanks for the PR! I have been too occupied on works to update this repo.

I have pulled the code down and have found some problems, I'd be grateful if you could fix them in your repo before I merge the code:

  1. The change of the template should happen in src/scripts/templates/iconpicker.coffee.
  2. The carets on the buttons now face up instead of face down.
  3. The popover now opens on the top of the button instead of below the button.

@sanyam-j
Copy link
Author

@justin-lau Fixed all the issues. Thanks.

@bhalt
Copy link

bhalt commented Apr 19, 2016

can this be accepted @justin-lau ? Running into the same issue.

@justin-lau
Copy link
Owner

justin-lau commented Apr 20, 2016

@sanyam-j Sorry for the silence. I have never had the time to review this PR again. One way to quickly use this update on your project would be to use sanyam-j/ui-iconpicker directly from bower or npm. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants