Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the UI tests with the COOP/COEP headers #103

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 19, 2024

Fixes #93

This also helps prepare for #102, where two different libraries will be used for the communication between the main thread and the worker.

Changes

  • Add a new webServer to the Playwright config
  • Test accessing the site on http://localhost:8080 (COOP / COEP headers enabled)
  • Test accessing files from the kernel in both modes

@jtpio
Copy link
Member Author

jtpio commented Jul 19, 2024

CONSOLE MSG --- File system calls over Atomics.wait is only supported with jupyterlite>=0.4.0a3

The UI test with the stable jupyterlite-core is failing, which is expected.

@jtpio jtpio marked this pull request as ready for review July 19, 2024 10:41
@jtpio jtpio changed the title Add Playwright webserver with COOP/COEP headers Run the UI tests with the COOP/COEP headers Jul 19, 2024
@jtpio
Copy link
Member Author

jtpio commented Jul 19, 2024

This should be good for now, and CI is now passing.

@jtpio jtpio requested a review from martinRenou July 19, 2024 10:42
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 235f00e into jupyterlite:main Jul 22, 2024
14 checks passed
@jtpio jtpio deleted the test-sharedarraybuffer branch July 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI tests for accessing contents via the SharedArrayBuffer
2 participants