Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coincident if crossOriginIsolated, comlink otherwise #102

Closed
jtpio opened this issue Jul 18, 2024 · 2 comments · Fixed by #108
Closed

Use coincident if crossOriginIsolated, comlink otherwise #102

jtpio opened this issue Jul 18, 2024 · 2 comments · Fixed by #108

Comments

@jtpio
Copy link
Member

jtpio commented Jul 18, 2024

Similar to jupyterlite/pyodide-kernel#126

jupyterlite-xeus should use coincident if crossOriginIsolated, comlink otherwise, to fix the issue noticed in jupyterlite/jupyterlite#1424.

As a follow-up to #87

@jtpio
Copy link
Member Author

jtpio commented Jul 25, 2024

Of note, coincident v2 was just released: https://github.com/WebReflection/coincident/releases/tag/v2.0.0

One of the changes is:

the "maybe available" SharedArrayBuffer issue has been fully solved via sabayon which guarantee functionality with or without special headers enabled and it allows people to provide their Service Worker as long as they add sabayon features

So maybe updating to the new version will remove the need for comlink (to be confirmed).

@martinRenou
Copy link
Member

martinRenou commented Jul 25, 2024

it allows people to provide their Service Worker

This is a red flag for me though. Regular async postMessage (what comlink does) should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants