-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileSystem calls over Atomics.wait instead of service worker when available #114
Conversation
Oh there are no visual regression tests testing the code execution. That makes me uncomfortable :) |
Well at least we have the readthedocs build for trying |
Let's get #115 in first |
c1e524c
to
3e2cd9d
Compare
3e2cd9d
to
ba9de02
Compare
On RTD, this still demonstrates jupyterlite/jupyterlite#1412 . If that gets fixed over there, we need that to land a PR and ship another beta there before this can be reviewed. If this is going to get fixed on this side, it has to happen either on a separate PR, or on this PR, before it can be properly reviewed. |
jupyterlite/jupyterlite#1412 mentions the build on the JupyterLite repo, which likely uses an old release of Could it be because that RTD demo uses the latest JupyterLite, but an older |
I've looked deeper into it, I believe jupyterlite/jupyterlite#1418 should fix it. Can you give it a try? I see it working there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
FYI @bollwyvl If that looks good to you, we can likely move forward with JupyterLite 0.4.0 and release final in the coming days. |
Won't be able to review much this weekend, but will roll it on conda-forge and see what we get... |
This has the implication of moving from using
comlink
to usingcoincident
for the Main <-> Worker communcication