-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: update the build system to use hatch and update dependency versions #9
base: main
Are you sure you want to change the base?
Conversation
@@ -1,24 +0,0 @@ | |||
import json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this file handlers.py
isn't needed now?
@jtpio Hello! |
Thanks @horw for cleaning this up! Indeed the repo is a bit outdated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Left a couple of comments, which will hopefully help with the CI too.
"@jupyterlite/kernel": "^0.1.0-alpha.10", | ||
"@jupyterlite/server": "^0.1.0-alpha.10" | ||
"@jupyterlab/coreutils": "^6.1.1", | ||
"@jupyterlite/contents": "^0.5.0-alpha.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can now update to ^0.5.0
? https://github.com/jupyterlite/jupyterlite/releases/tag/v0.5.0
"Framework :: Jupyter :: JupyterLab :: 3", | ||
"Framework :: Jupyter :: JupyterLab :: Extensions", | ||
"Framework :: Jupyter :: JupyterLab :: Extensions :: Prebuilt", | ||
from setuptools import setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this setup.py
file can now be simplified if most of the build logic is handled in pyproject.toml
, like in the extension template: https://github.com/jupyterlab/extension-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can likely replace it by the following:
__import__("setuptools").setup()
The Jupyter build system was outdated, so this kernel needs to be migrated to the Hatch build system, which supports shareable files. On the other hand, JupyterLite has been significantly updated, with many new features now available.
The base for this PR was https://github.com/jupyterlite/pyodide-kernel, as it seemed to have been updated quite recently. However, it's too complicated, which is where echo-kernel shines — it provides an easy, not-overwhelming template example.
How to Start Dev Server
npm run setup:py jlpm install jlpm build jupyter labextension develop . --overwrite jupyter lite serve
Further Steps
Related
Closes #8