New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use xtermjs onData rather than onKey #78

Merged

ianthomas23 merged 1 commit into main from onData

Nov 28, 2024

Member

ianthomas23 commented Nov 28, 2024

Use xtermjs onData rather than onKey for the demo as that is what is used in JupyterLab:
https://github.com/jupyterlab/jupyterlab/blob/48908a8b07128b651faab72434f8d442b99bc91c/packages/terminal/src/widget.ts#L366

This supports better mapping of keys to characters, and also pasting into the terminal.


          Use xtermjs onData rather than onKey

b74c5bf

ianthomas23 added the enhancement label

ianthomas23 merged commit d473de0 into main

7 checks passed

ianthomas23 deleted the onData branch

November 28, 2024 17:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels