Obtain wasm packages from emscripten-forge when building deployment #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
wasm-pkg-config
branch
from
e8e6417 to
4b09077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the configuration and packaging of wasm command files to occur when building a deployment (static website) rather than being hard-coded in the
cocklesource code and the wasm files being packed in the NPM package. The process is similar to that performed for python xeus kernels in JupyterLite except that the code here is TypeScript rather than Python. There is an input JSON fileconfig-cockle-base.jsoncontaining configuration for compulsory wasm packages (cockle_fs,coreutilsandgrep) which ships withcockle, and this can be added with an extra config file to add optional wasm packages such aslua. A JSON config file is placed alongside the wasm files when a deployment is created, andShellImplreads this config file to configure the variousWasmCommandRunnerobjects.Probably lots of the internal details will change. The JSON file formats should be in schemas, and the
prepare_wasmnode tool script should be more robust. It would be simpler for end-users if instead of using a bespoke JSON file a normalmicromambaenvironment file could be used (as with python xeus), but for this we would need some other way to also configure which emscripten-forge packages contain which wasm modules and which commands. These could probably be embedded in the emscripten-forge packages in some way.After merging this will need a new
cocklerelease before it can be tried out in JupyterLite.