Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm from emscripten #25

Closed
wants to merge 16 commits into from
Closed

Conversation

DerThorsten
Copy link
Contributor

  • fetch emscripten-wasm32 binaries from emscripten forge
  • allow emscripten-wasm32 binaries with js+wasm files
  • removed test hack to pretend this is a browser and not node (this did not worked when a *.wasm file needs to be loaded, also the emscripten compiled binaries now support the node env (at least lua, grep and coreutils)
  • Added lua command to check if binaries with wasm files work
  • Use micromamba in ci since we need a installed micromamba for fetching pkgs from emscripten forge

@DerThorsten DerThorsten added the enhancement New feature or request label Jul 23, 2024
@ianthomas23
Copy link
Member

I've been experimenting with this and after the recent changes to the CI here and the emscripten forge package building I can get it working for just the cockle-fs, coreutils and grep modules as they currently stand. So that's the building, testing and packaging here and using it in the terminal extension. Trying to incorporate lua with a separate WASM file still gives me a number of problems at packaging and runtime.

So perhaps the best approach going forward is to split into 3 units of work:

  1. Copy the current cockle-fs, coreutils and grep modules (WASM embedded in JS) from emscripten forge using a micromamba environment.
  2. Split those 3 packages into separate JS and WASM files and get them working.
  3. Add lua.

@DerThorsten If you are happy with this approach, I can submit a PR for item 1 soon, suitably attributed to yourself of course.

@DerThorsten
Copy link
Contributor Author

I've been experimenting with this and after the recent changes to the CI here and the emscripten forge package building I can get it working for just the cockle-fs, coreutils and grep modules as they currently stand. So that's the building, testing and packaging here and using it in the terminal extension. Trying to incorporate lua with a separate WASM file still gives me a number of problems at packaging and runtime.

So perhaps the best approach going forward is to split into 3 units of work:

  1. Copy the current cockle-fs, coreutils and grep modules (WASM embedded in JS) from emscripten forge using a micromamba environment.
  2. Split those 3 packages into separate JS and WASM files and get them working.
  3. Add lua.

@DerThorsten If you are happy with this approach, I can submit a PR for item 1 soon, suitably attributed to yourself of course.

sorry for the late reply. I am happy with the approach!

@ianthomas23
Copy link
Member

Closing this as it has all been implemented in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants