Support terminal handling of columns #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for correct terminal handling of number of columns, set using
Shell.setSize. An example of a command that uses this isls, which by default writes the file and directory list in a number of columns that fit in the terminal width.The terminal size is stored as environment variables
LINESandCOLUMNS. These can be checked using the commandsenvorstty size.In terms of implementation, if
stdinis not specified when loading the JS/WASM command file then stdin is a valid TTY. To get this to work as we desire two functions are monkey-patched, one which returns the window size (otherwise hard-coded as 24x80) and the other is theget_charfunction by which we pass in stdin characters one at a time.I have modified both
coreutils.jsandgrep.jsto exportTTYas this is needed for the monkey-patching. This change will have to be repeated in the emscripten forge recipes.There is no coloured terminal output yet.