Skip to content

Commit

Permalink
Add GSoC report (#26)
Browse files Browse the repository at this point in the history
* Update README.md 2

* Update README.md 2.1

final changes as per GSOC requirements

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

Co-authored-by: Frédéric Collonval <[email protected]>

* Update README.md

* Improve the readme

* Fix prettier check

* Fix typo

---------

Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
  • Loading branch information
3 people authored Jul 31, 2024
1 parent fffb100 commit 58146d8
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 7 deletions.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ node_modules
**/package.json
!/package.json
jupyter_builder
*.md
69 changes: 62 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
# Jupyter Builder - GSoC 2024
# Jupyter Builder

Build tools for JupyterLab (and remixes)

> This _will_ start as an extraction of the builder tools currently included in
> the core [JupyterLab](https://github.com/jupyterlab/jupyterlab).
> \[!NOTE\]
> This started by the extraction of the builder tools included in
> the core [JupyterLab](https://github.com/jupyterlab/jupyterlab) during a GSoC project. See [below](#gsoc-2024-anecdote) for more information.
## Why extracting the build tools?

- This would also solve some chicken-and-egg problems like jupyterlab/jupyterlab_pygments#23.
- Isolating the builder functionalities will simplify the work
of core and extension developers who can now focus on their respective parts of the
codebase instead of the earlier intertwined code. It will in particular reduce the need to update the maintenance tooling to produce extension compatible with newer version of Jupyter app.
codebase instead of the earlier intertwined code.
- It will in particular reduce the need to update the maintenance tooling to produce extension compatible with newer version of Jupyter app.

## How to install the package?

Expand All @@ -29,11 +31,11 @@ pip install jupyter_builder
```
- `develop` : Install the Jupyter extension JavaScript assets in dev mode for consumption in the Jupyter app. It similar to [editable install mode of pip](https://pip.pypa.io/en/stable/topics/local-project-installs/#editable-installs)
```
jupyter-builder develop --overwrite (path to extension folder)
jupyter-builder develop --overwrite <path to extension folder>
```
- `watch` : Automatically rebuild the development JavaScript assets when one file is changed to ease development.
```
jupyter-builder watch (path to extension folder)
jupyter-builder watch <path to extension folder>
```
- Provides a NPM package manager: `jlpm`
Expand All @@ -45,4 +47,57 @@ Execute the following command in a terminal:
pip uninstall jupyter_builder
```
See https://github.com/jupyterlab/jupyterlab/issues/13456
______________________________________________________________________
## GSoC 2024 Anecdote
> Written by [@cronan03](https://github.com/cronan03) - GSoC Contributor 2024
### Goal
The goals of this project are:
- to extract that tooling as a new separate package to ease maintenance (for core and extension developers)
- update the existing package to use the new one
- make it configurable to be reused for other applications.
### What I did
1. Successfully created a CLI with the processes `develop`, `build` and `watch` mentioned above.
1. Created extensive unit tests using `Pytest` to ensure the processes run efficiently on any OS.
1. Reduced external dependencies by bringing `jlpm` and `jupyterlab.semver` to the package.
1. Pre released the package. It can be found on Pypi here https://pypi.org/project/jupyter-builder/
1. Initiated a solution to the issue https://github.com/jupyterlab/jupyterlab/issues/13456
### What's left to do
1. We should bring `@jupyterlab/builder` within this package and make it generic.
For now the code lives there: https://github.com/jupyterlab/jupyterlab/tree/main/builder
1. https://github.com/jupyterlab/jupyter-builder/blob/fffb100fc57ecb147bface4441f91bfd0cb6ff9a/jupyter_builder/federated_extensions.py#L296 which is responsible for checking version overlap has been temporarily ignored to make the build feature work.
1. Update JupyterLab core to use this new package
### Merged PRs
1. https://github.com/jupyterlab/jupyter-builder/pull/11
- This PR focuses on extracting the `develop` feature which is responsible for installing the Jupyter extension JS assets in dev mode.
- Considering the size of [labextension.py](https://github.com/jupyterlab/jupyterlab/blob/main/jupyterlab/labextensions.py), only features essential to Jupyter builder were added.
- Each of the features will inherit from the class `BaseExtensionApp` present [here](https://github.com/jupyterlab/jupyter-builder/blob/main/jupyter_builder/base_extension_app.py)
- The [federated_extensions.py](https://github.com/jupyterlab/jupyter-builder/blob/main/jupyter_builder/federated_extensions.py) sets up and executes commands to build, develop and waatch a JupyterLab extension. It resolves paths, constructs the appropriate command-line arguments, and executes the build process using `subprocess.check_call`. Optional parameters allow for customization of the build process, including logging, development mode, and source map generation.
1. https://github.com/jupyterlab/jupyter-builder/pull/13
- This PR focuses on extracting the `build` feature which is responsible for creating the Javascript assets which will be consumed by the Jupyter App.
- It will always result in the creation of a file `static/style.js` in `<extension_folder>/myextension/labextension`.
- Tests have been crafted using `Pytest` to check for the existence of files mentioned above on running the `build` command.
1. https://github.com/jupyterlab/jupyter-builder/pull/18
- The `watch` feature on running will rebuild the JS assets on being triggered. This happens on changing contents in `<extension_folder>/src/index.ts`
- To test this feature we deliberately make a change in `index.ts` triggering `watch`. This replaces old JS assets with new ones having different hash values in the file names. We create 2 vectors of filenames before and after triggering `watch` which will tell us if it actually worked.
1. https://github.com/jupyterlab/jupyter-builder/pull/20
- To reduce external dependencies, we added `jlpm` to this package.
- It existed [here](https://github.com/jupyterlab/jupyterlab/blob/main/jupyterlab/jlpmapp.py) with the [entrypoint](https://github.com/jupyterlab/jupyterlab/blob/e048f27548969c0e4403417ac04bc186f119128f/pyproject.toml#L60).
1. https://github.com/jupyterlab/jupyter-builder/pull/22
- Documented the working of the Jupyter builder along with installation guide.
### Challenges and Learning
1. One of the main challenges was starting this project from scratch with no pre existing code to rely on. I thank my mentor [@fcollonval](https://github.com/fcollonval) for creating the skeleton in https://github.com/jupyterlab/jupyter-builder/pull/2 which gave me a base to work on.
1. Selecting relevant features for Jupyter builder from [labextension.py](https://github.com/jupyterlab/jupyterlab/blob/main/jupyterlab/labextensions.py) was really tough without a thorough understanding on which functions Jupyter builder would actually rely on.
1. Creating tests for the `watch` feature was tricky as I had to carefully adjust sleep times to make sure the function was running before a change in `<extension_folder>/src/index.ts` was made. Otherwise the change happened before `watch` ran and never triggered it.

0 comments on commit 58146d8

Please sign in to comment.