Set nginx-ingress timeout to 10 minutes to improve support for websockets #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default nginx-ingress timeout is 60 seconds. This means Jupyter desktops will disconnect if there are no changes on screen for 60 seconds. There's a race condition here between the nginx timeout and the desktop clock which updates every minute which is why
https://mybinder.org/v2/gh/jupyterhub/jupyter-remote-desktop-proxy/HEAD?urlpath=desktop
doesn't always timeout after 1 minute.
If you use a desktop without a clock:
https://mybinder.org/v2/gh/manics/jupyter-desktop-mate/HEAD?urlpath=desktop
the timeout is more reproducible.
I've set it to 10 minutes, though maybe we should lower it to 5 minutes?