Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix failure to log error after all retries failed #441

Merged
merged 1 commit into from
Jan 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def wait_until_urlopen(url, **kwargs):
urlopen(url, **kwargs)
break
except URLError:
retries -= 1
if not retries:
print(
f"{url} not ready, aborting",
Expand All @@ -109,7 +110,6 @@ def wait_until_urlopen(url, **kwargs):
f"{url} not ready, will try again in 0.5s [{retries} retries]",
flush=True,
)
retries -= 1
time.sleep(0.5)


Expand Down