Verify support for Python 3.12

jupyterhub · Apr 27, 2024 · a06b49e · a06b49e
1 parent fff7d4f
commit a06b49e
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 12 deletions.
diff --git a/.github/workflows/linkcheck.yaml b/.github/workflows/linkcheck.yaml
@@ -24,7 +24,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.12"
 
       - name: Install deps
         run: pip install -r docs/requirements.txt

diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -36,7 +36,7 @@ jobs:
 
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.12"
 
       - uses: actions/setup-node@v4
         with:
@@ -90,7 +90,7 @@ jobs:
     steps:
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.12"
 
       - name: Download artifacts from build
         uses: actions/download-artifact@v4

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -40,7 +40,7 @@ jobs:
 
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.12"
 
       - uses: actions/setup-node@v4
         with:
@@ -74,19 +74,26 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-22.04, windows-2022]
-        python-version: ["3.8", "3.11"]
-        pip-extras: ["lab", "classic"]
+        python-version: ["3.8", "3.12"]
+        pip-extras: [lab, classic]
         pip-install-constraints: [""]
         exclude:
           # windows should work for all test variations, but a limited selection
           # is run to avoid doubling the amount of test runs
           - os: windows-2022
-            python-version: "3.11"
+            python-version: "3.12"
             pip-extras: classic
           - os: windows-2022
             python-version: "3.8"
             pip-extras: lab
 
+          # FIXME: If https://github.com/jupyter/notebook/pull/7305 gets merged
+          #        and released, we can test "classic" with python 3.12 as well,
+          #        but until then we exclude it from being run as a Python 3.12
+          #        test and include it as a Python 3.11 test.
+          - os: ubuntu-22.04
+            python-version: "3.12"
+            pip-extras: classic
         include:
           # this test is manually updated to reflect the lower bounds of
           # versions from dependencies
@@ -99,6 +106,11 @@ jobs:
               tornado==6.1.0
               traitlets==5.1.0
 
+          # Workaround for excluded 3.12 test mentioned in a FIXME above
+          - os: ubuntu-22.04
+            python-version: "3.11"
+            pip-extras: classic
+
     steps:
       - uses: actions/checkout@v4
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -25,7 +25,7 @@ For example, after installing [`mambaforge`](https://conda-forge.org/miniforge),
 create a new environment with all heavy development and test dependencies:
 
 ```yaml
-mamba create --name=jupyter-server-proxy --channel=conda-forge "python=3.11" "nodejs=20" pip git geckodriver firefox
+mamba create --name=jupyter-server-proxy --channel=conda-forge "python=3.12" "nodejs=20" pip git geckodriver firefox
 mamba activate jupyter-server-proxy
 ```
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -40,10 +40,6 @@ classifiers = [
     "Operating System :: POSIX :: Linux",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
-    "Programming Language :: Python :: 3.9",
-    "Programming Language :: Python :: 3.10",
-    "Programming Language :: Python :: 3.11",
 ]
 dependencies = [
     "aiohttp",