Modernize event loop behavior #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Jan 2, 2024
Done, thank you! |
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Jul 31, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated since Python 3.10 and will be an error in some future Python release [1]. Using it causes errors in IPython when using a RemotePlace. Instead of using asyncio.get_event_loop(), add a new helper function ensure_event_loop(): Try to retrieve the OS thread's event loop from a ContextVar. If the ContextVar is not set yet, try to get the current loop from asyncio.get_running_loop() and store it in the ContextVar. If there is no loop, create a new one, set it as the current event loop for the current thread and store in the ContextVar. Finally return the found or newly created loop. This behavior mimics what asyncio.get_event_loop() did. It is also used by jupyter_core [2]. [1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop [2] jupyter/jupyter_core#387 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Jul 31, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated since Python 3.10 and will be an error in some future Python release [1]. Using it causes errors in IPython when using a RemotePlace. Instead of using asyncio.get_event_loop(), add a new helper function ensure_event_loop(): Try to retrieve the OS thread's event loop from a ContextVar. If the ContextVar is not set yet, try to get the current loop from asyncio.get_running_loop() and store it in the ContextVar. If there is no loop, create a new one, set it as the current event loop for the current thread and store in the ContextVar. Finally return the found or newly created loop. This behavior mimics what asyncio.get_event_loop() did. It is also used by jupyter_core [2]. [1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop [2] jupyter/jupyter_core#387 Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 1, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 1, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 1, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 7, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 7, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 7, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 8, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 8, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 13, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to labgrid-project/labgrid
that referenced
this pull request
Aug 13, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
added a commit
to Bastian-Krause/labgrid
that referenced
this pull request
Aug 13, 2024
Calling asyncio.get_event_loop() with no current event loop is deprecated
since Python 3.10 and will be an error in some future Python release
[1]. Using it in labgrid.remote.client.start_session() causes errors in
IPython when using a RemotePlace:
In [1]: from labgrid.resource.remote import RemotePlace
...: from labgrid import Target
...:
...: target = Target("example")
...: RemotePlace(target, name="example-place")
[...]
RuntimeError: There is no current event loop in thread 'MainThread'.
For labgrid.remote.client.start_session() there is no reliable way of
retrieving the thread's event loop without being called from an async
context (which we cannot assume here). Instead of using
asyncio.get_event_loop(), use a new helper function ensure_event_loop()
that returns the first available loop instance from:
- externally provided event loop
- stashed event loop
- OS thread's running event loop (when called from async code)
- new event loop
The returned loop is stashed for future calls. See also [2] for a
similar approach.
start_session() now accepts a new optional argument "loop" for providing
an external event loop.
[1] https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
[2] jupyter/jupyter_core#387
Signed-off-by: Bastian Krause <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in python/cpython#100160, we should not be relying on
asyncio.get_event_loop, since they are in fact going to make it an alias forasyncio.get_running_loop.This ensures we install an event loop before launching our apps, so we should not see any more issues like jupyter/notebook#6721.
Additionally, it adds a new class,
JupyterAsyncAppthat runsinitialize_async()andstart_async()in an event loop.Based on results in ipython/ipykernel#1184, we'll want to normally use the default event loop on Windows, unless we know we're running a tornado app. This PR adds a
prefer_selector_loopoption toensure_event_loopso we can override_prefer_selector_loopinjupyter_serverapps to prefer the selector loop.Based on failures seen in #383, we add tests to ensure we are not interfering with existing event loop behavior.