This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Simplify backend init func #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JS code in Py/R/Scala code seems the same, can we move these JS code to the `nb-extension/init/init.js` file (which will be run in load_ipython_extension? By doing so, init function in kernel side can be simplified or even removed, so that the notebook user (Py/R/Scala) user won't need to run init function in kernel. (For this commit, users don't need to run `declarativewidgets.init()` any longer in Python)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS code in Py/R/Scala init() function seems to be same, can we move these JS code to the
nb-extension/init/init.jsfile (which will be run in load_ipython_extension?By doing so, init() function in kernel side can be simplified or even removed, so that the notebook user (Py/R/Scala) user won't need to run the
init()function in kernel.For this commit, users don't need to run
declarativewidgets.init()any longer in Python.