Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check on self::$post #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TomAuger
Copy link

This required validation filter is only useful when we have an uploaded file, hence a populated self::$post, but PHP will issue a warning when attempting to dereference self::$post->ID when there's no uploaded file (but the filter still runs) unless wrapped in isset() or empty().

This required validation filter is only useful when we have an uploaded file, hence a populated `self::$post`, but PHP will issue a warning when attempting to dereference `self::$post->ID` when there's no uploaded file (but the filter still runs) unless wrapped in `isset()` or `empty()`.
@jupitercow
Copy link
Owner

I will be working on the plugin this week, so I will take a look at this
and having any required updates added in the new version.

On Thu, Feb 18, 2016 at 8:22 PM TomAuger [email protected] wrote:

This required validation filter is only useful when we have an uploaded
file, hence a populated self::$post, but PHP will issue a warning when
attempting to dereference self::$post->ID when there's no uploaded file

(but the filter still runs) unless wrapped in isset() or empty().

You can view, comment on, or merge this pull request online at:

#6
Commit Summary

  • Add check on self::$post

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants