Skip to content

Commit

Permalink
feat: Node min version is actually 18, not LTS
Browse files Browse the repository at this point in the history
  • Loading branch information
peterpeterparker committed Nov 10, 2023
1 parent e248796 commit 748c9ef
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/constants/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const MISSION_CONTROL_WASM_NAME = 'mission_control';
export const ORBITER_WASM_NAME = 'orbiter';
export const UPLOAD_BATCH_SIZE = 20;
export const COLLECTION_DAPP = '#dapp';
export const NODE_LTS = 18;
export const NODE_18 = 18;
export const CONSOLE_URL = 'https://console.juno.build';
export const CONSOLE_SATELLITE_URL = `${CONSOLE_URL}/satellite/?s=`;
export const JUNO_CDN_URL = 'https://fmkjf-bqaaa-aaaal-acpza-cai.raw.icp0.io';
Expand Down
8 changes: 4 additions & 4 deletions src/utils/env.utils.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import {green, yellow} from 'kleur';
import {major} from 'semver';
import {NODE_LTS} from '../constants/constants';
import {NODE_18} from '../constants/constants';

export const checkNodeVersion = (): {valid: boolean} => {
try {
const {version} = process;
const nodeMajor = major(version);

if (nodeMajor < NODE_LTS) {
if (nodeMajor < NODE_18) {
console.log(
`Your version of Node is ${yellow(`${version}`)}. Juno CLI requires Node ${green(
`${NODE_LTS}.x`
)} LTS.`
`${NODE_18}`
)} or a more recent version.`
);
return {valid: false};
}
Expand Down

0 comments on commit 748c9ef

Please sign in to comment.