Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for TLS-ALPN-01 ACME protocol #168

Merged
merged 16 commits into from
Jul 23, 2024
Merged

feat: Support for TLS-ALPN-01 ACME protocol #168

merged 16 commits into from
Jul 23, 2024

Conversation

junkurihara
Copy link
Owner

This PR solves #146

Important Changes

  • Breaking: Experimental TLS-ALPN-01 ACME support is added. Check the new configuration options and README.md for ACME support. Note that it is still under development and may have some issues.

Improvement

  • Refactor: lots of minor improvements
  • Deps

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Secrets Audit 0 29 0 0
Security Audit for Infrastructure 0 3 0 3
Shell Script Analysis 0 0 0 0

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@junkurihara
Copy link
Owner Author

At this point, the functionality works with Let'sEncrypt production environment with multiple domain names concurrently on the single host

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan Summary

Tool Critical High Medium Low Status
Secrets Audit 0 29 0 0
Shell Script Analysis 0 0 0 0
Security Audit for Infrastructure 0 3 0 3

Recommendation

Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍

@junkurihara junkurihara marked this pull request as ready for review July 23, 2024 16:12
@junkurihara junkurihara merged commit f1eb2f3 into develop Jul 23, 2024
2 of 10 checks passed
@junkurihara junkurihara deleted the feat/acme branch July 23, 2024 16:18
@junkurihara junkurihara mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant