Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size check of arrays when broadcasting #296

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Fix size check of arrays when broadcasting #296

merged 5 commits into from
Aug 1, 2024

Conversation

odow
Copy link
Member

@odow odow commented Aug 1, 2024

Closes #295

The previous check for length is incorrect because it ignores length 1 dimensions. But the comment explains some arrays do not support size. Which? SparseAxisArray? Do we really support broadcasting over that?

@odow odow changed the title WIP: Fix size check of arrays when broadcasting Fix size check of arrays when broadcasting Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.74%. Comparing base (0e42a16) to head (d5c3985).

Files Patch % Lines
src/broadcast.jl 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   91.85%   91.74%   -0.11%     
==========================================
  Files          23       23              
  Lines        2209     2216       +7     
==========================================
+ Hits         2029     2033       +4     
- Misses        180      183       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow requested a review from blegat August 1, 2024 03:50
@blegat
Copy link
Member

blegat commented Aug 1, 2024

This is an issue you detected with the integration script: #160
Maybe we should check which one it was and update the comment

@odow
Copy link
Member Author

odow commented Aug 1, 2024

Oooo. That's a bad bug for me to introduce.

It was SparseAxisArray because when I had size the JuMP tests failed.

@odow odow merged commit 1e73552 into master Aug 1, 2024
9 of 11 checks passed
@odow odow deleted the od/fix-broadcast branch August 1, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Element-wise comparisons accept invalid dimension mismatch
2 participants