-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote div and / in the same way #270
Conversation
Nice! Could you add a new test for this to the bottom of https://github.com/jump-dev/MutableArithmetics.jl/blob/master/test/interface.jl? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 91.71% 91.95% +0.23%
==========================================
Files 23 23
Lines 2173 2200 +27
==========================================
+ Hits 1993 2023 +30
+ Misses 180 177 -3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Oscar Dowson <[email protected]>
I added a test 😃 |
Co-authored-by: Oscar Dowson <[email protected]>
The formatter is very particular 😄 but it does help unify the code across all of |
That's alright 😄 |
The current operation promotion falls back to
0 / 1
for/
, butdiv(0, 0)
fordiv
, giving theDivideError
in #240.This fixes that.