Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote div and / in the same way #270

Merged
merged 6 commits into from
Mar 24, 2024
Merged

Promote div and / in the same way #270

merged 6 commits into from
Mar 24, 2024

Conversation

hersle
Copy link
Contributor

@hersle hersle commented Mar 20, 2024

The current operation promotion falls back to 0 / 1 for /, but div(0, 0) for div, giving the DivideError in #240.
This fixes that.

@odow
Copy link
Member

odow commented Mar 20, 2024

Nice! Could you add a new test for this to the bottom of https://github.com/jump-dev/MutableArithmetics.jl/blob/master/test/interface.jl?

src/interface.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (5e901e1) to head (d2c8341).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   91.71%   91.95%   +0.23%     
==========================================
  Files          23       23              
  Lines        2173     2200      +27     
==========================================
+ Hits         1993     2023      +30     
+ Misses        180      177       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hersle
Copy link
Contributor Author

hersle commented Mar 21, 2024

I added a test 😃

test/interface.jl Outdated Show resolved Hide resolved
hersle and others added 2 commits March 21, 2024 21:05
Co-authored-by: Oscar Dowson <[email protected]>
@odow
Copy link
Member

odow commented Mar 21, 2024

The formatter is very particular 😄 but it does help unify the code across all of jump-dev.

@hersle
Copy link
Contributor Author

hersle commented Mar 22, 2024

That's alright 😄

@odow odow merged commit a9779ff into jump-dev:master Mar 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants