Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an operate method for abs #243

Merged
merged 1 commit into from
Nov 27, 2023
Merged

add an operate method for abs #243

merged 1 commit into from
Nov 27, 2023

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Nov 27, 2023

Fixes #241

@nsajko
Copy link
Contributor Author

nsajko commented Nov 27, 2023

There's no tests here because #242 isn't merged yet. After it's merged abs just has to be added to the tested unary operations.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac7a8a9) 89.65% compared to head (f520983) 89.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   89.65%   89.66%           
=======================================
  Files          23       23           
  Lines        2156     2157    +1     
=======================================
+ Hits         1933     1934    +1     
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Nov 27, 2023

Can be rebased onto master and a test added

@odow odow merged commit 4cc20ad into jump-dev:master Nov 27, 2023
11 checks passed
@nsajko nsajko deleted the operate_abs branch November 30, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

no operate method for abs
2 participants