WIP: experiment replacing rewrite with MutableArithmetics2 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.34% // Head: 82.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## od/rewrite-2 #172 +/- ##
================================================
- Coverage 84.34% 82.01% -2.33%
================================================
Files 21 21
Lines 1999 1857 -142
================================================
- Hits 1686 1523 -163
- Misses 313 334 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
So this is still breaking on the JuMP side, but it's just a few changes in error types. |
odow
force-pushed
the
od/rewrite-2
branch
3 times, most recently
from
133b711 to
3deb169
Compare
|
Closing because #170 is now a feature addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a breaking change because it removes
rewrite_generator, but it's useful to see how the tests fare, etc.